Skip to content

Commit

Permalink
Staging: cx25821: fix double unlock in medusa_video_init()
Browse files Browse the repository at this point in the history
medusa_set_videostandard() takes the lock but it always drops it before
returning.

This was found with a static checker and compile tested only.  :/

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Dan Carpenter authored and Greg Kroah-Hartman committed Mar 4, 2010
1 parent 4b2ba24 commit 7a02f54
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/staging/cx25821/cx25821-medusa-video.c
Original file line number Diff line number Diff line change
Expand Up @@ -795,10 +795,8 @@ int medusa_video_init(struct cx25821_dev *dev)
value &= 0xFFFFFFDF;
ret_val = cx25821_i2c_write(&dev->i2c_bus[0], MON_A_CTRL, value);

if (ret_val < 0) {
mutex_unlock(&dev->lock);
if (ret_val < 0)
return -EINVAL;
}

mutex_unlock(&dev->lock);

Expand Down

0 comments on commit 7a02f54

Please sign in to comment.