Skip to content

Commit

Permalink
dql: make dql_init return void
Browse files Browse the repository at this point in the history
dql_init always returned 0, and the only place that uses it
in network core code didn't care about the return value anyway.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Acked-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Stephen Hemminger authored and David S. Miller committed Oct 19, 2017
1 parent be070c7 commit 7a0947e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion include/linux/dynamic_queue_limits.h
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ void dql_completed(struct dql *dql, unsigned int count);
void dql_reset(struct dql *dql);

/* Initialize dql state */
int dql_init(struct dql *dql, unsigned hold_time);
void dql_init(struct dql *dql, unsigned int hold_time);

#endif /* _KERNEL_ */

Expand Down
3 changes: 1 addition & 2 deletions lib/dynamic_queue_limits.c
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,11 @@ void dql_reset(struct dql *dql)
}
EXPORT_SYMBOL(dql_reset);

int dql_init(struct dql *dql, unsigned hold_time)
void dql_init(struct dql *dql, unsigned int hold_time)
{
dql->max_limit = DQL_MAX_LIMIT;
dql->min_limit = 0;
dql->slack_hold_time = hold_time;
dql_reset(dql);
return 0;
}
EXPORT_SYMBOL(dql_init);

0 comments on commit 7a0947e

Please sign in to comment.