Skip to content

Commit

Permalink
bcache: add code comments for state->pool in __btree_sort()
Browse files Browse the repository at this point in the history
To explain the pages allocated from mempool state->pool can be
swapped in __btree_sort(), because state->pool is a page pool,
which allocates pages by alloc_pages() indeed.

Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Coly Li authored and Jens Axboe committed Jan 23, 2020
1 parent 0e0c123 commit 7a0bc2a
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/md/bcache/bset.c
Original file line number Diff line number Diff line change
Expand Up @@ -1257,6 +1257,11 @@ static void __btree_sort(struct btree_keys *b, struct btree_iter *iter,
* Our temporary buffer is the same size as the btree node's
* buffer, we can just swap buffers instead of doing a big
* memcpy()
*
* Don't worry event 'out' is allocated from mempool, it can
* still be swapped here. Because state->pool is a page mempool
* creaated by by mempool_init_page_pool(), which allocates
* pages by alloc_pages() indeed.
*/

out->magic = b->set->data->magic;
Expand Down

0 comments on commit 7a0bc2a

Please sign in to comment.