Skip to content

Commit

Permalink
net: phy: broadcom: Add power down exit reset state delay
Browse files Browse the repository at this point in the history
Per the datasheet, when we clear the power down bit, the PHY remains in
an internal reset state for 40us and then resume normal operation.
Account for that delay to avoid any issues in the future if
genphy_resume() changes.

Fixes: fe26821 ("net: phy: broadcom: Wire suspend/resume for BCM54810")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Florian Fainelli authored and David S. Miller committed Mar 12, 2021
1 parent a9f8124 commit 7a1468b
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/net/phy/broadcom.c
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,11 @@ static int bcm54xx_resume(struct phy_device *phydev)
if (ret < 0)
return ret;

/* Upon exiting power down, the PHY remains in an internal reset state
* for 40us
*/
fsleep(40);

return bcm54xx_config_init(phydev);
}

Expand Down

0 comments on commit 7a1468b

Please sign in to comment.