Skip to content

Commit

Permalink
binfmt_flat: provide an asm-generic/flat.h
Browse files Browse the repository at this point in the history
This file implements the flat get/put reloc helpers for architectures
that do not need to overload the relocs by simply using get_user/put_user.

Note that many nommu architectures currently use {get,put}_unaligned, which
looks a little bogus and should probably later be switched over to this
version as well.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>
Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
  • Loading branch information
Christoph Hellwig authored and Greg Ungerer committed Jun 23, 2019
1 parent cf9a566 commit 7a8998c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 28 deletions.
1 change: 1 addition & 0 deletions arch/arm/include/asm/Kbuild
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ generic-y += early_ioremap.h
generic-y += emergency-restart.h
generic-y += exec.h
generic-y += extable.h
generic-y += flat.h
generic-y += irq_regs.h
generic-y += kdebug.h
generic-y += local.h
Expand Down
21 changes: 1 addition & 20 deletions arch/m68k/include/asm/flat.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,7 @@
#ifndef __M68KNOMMU_FLAT_H__
#define __M68KNOMMU_FLAT_H__

#include <linux/uaccess.h>

static inline int flat_get_addr_from_rp(u32 __user *rp, u32 relval, u32 flags,
u32 *addr, u32 *persistent)
{
#ifdef CONFIG_CPU_HAS_NO_UNALIGNED
return copy_from_user(addr, rp, 4) ? -EFAULT : 0;
#else
return get_user(*addr, rp);
#endif
}

static inline int flat_put_addr_at_rp(u32 __user *rp, u32 addr, u32 rel)
{
#ifdef CONFIG_CPU_HAS_NO_UNALIGNED
return copy_to_user(rp, &addr, 4) ? -EFAULT : 0;
#else
return put_user(addr, rp);
#endif
}
#include <asm-generic/flat.h>

#define FLAT_PLAT_INIT(regs) \
do { \
Expand Down
12 changes: 4 additions & 8 deletions arch/arm/include/asm/flat.h → include/asm-generic/flat.h
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
* arch/arm/include/asm/flat.h -- uClinux flat-format executables
*/

#ifndef __ARM_FLAT_H__
#define __ARM_FLAT_H__
#ifndef _ASM_GENERIC_FLAT_H
#define _ASM_GENERIC_FLAT_H

#include <linux/uaccess.h>

static inline int flat_get_addr_from_rp(u32 __user *rp, u32 relval, u32 flags,
u32 *addr, u32 *persistent)
u32 *addr, u32 *persistent)
{
#ifndef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
return copy_from_user(addr, rp, 4) ? -EFAULT : 0;
Expand All @@ -27,4 +23,4 @@ static inline int flat_put_addr_at_rp(u32 __user *rp, u32 addr, u32 rel)
#endif
}

#endif /* __ARM_FLAT_H__ */
#endif /* _ASM_GENERIC_FLAT_H */

0 comments on commit 7a8998c

Please sign in to comment.