Skip to content

Commit

Permalink
netlink: Do not subscribe to non-existent groups
Browse files Browse the repository at this point in the history
Make ABI more strict about subscribing to group > ngroups.
Code doesn't check for that and it looks bogus.
(one can subscribe to non-existing group)
Still, it's possible to bind() to all possible groups with (-1)

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Dmitry Safonov <dima@arista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dmitry Safonov authored and David S. Miller committed Jul 29, 2018
1 parent 9939a46 commit 7acf9d4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions net/netlink/af_netlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -1008,6 +1008,7 @@ static int netlink_bind(struct socket *sock, struct sockaddr *addr,
if (err)
return err;
}
groups &= (1UL << nlk->ngroups) - 1;

bound = nlk->bound;
if (bound) {
Expand Down

0 comments on commit 7acf9d4

Please sign in to comment.