Skip to content

Commit

Permalink
mtd: spi-nor: hisi-sfc: Add of_node_put() before break
Browse files Browse the repository at this point in the history
Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a break from the middle of the loop, there
is no put, thus causing a memory leak. Hence add an of_node_put before
the break.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
  • Loading branch information
Nishka Dasgupta authored and Tudor Ambarus committed Aug 28, 2019
1 parent 6597f0b commit 7ae2227
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/mtd/spi-nor/hisi-sfc.c
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ static int hisi_spi_nor_register_all(struct hifmc_host *host)

if (host->num_chip == HIFMC_MAX_CHIP_NUM) {
dev_warn(dev, "Flash device number exceeds the maximum chipselect number\n");
of_node_put(np);
break;
}
}
Expand Down

0 comments on commit 7ae2227

Please sign in to comment.