Skip to content

Commit

Permalink
iio: health: max30102: Fix mode config values
Browse files Browse the repository at this point in the history
Table 4 of the datasheet specifies the mode control, these are not
individual bits; add multi LED mode

Add multi-LED mode and fix MODE_MASK (3 bits wide, not 2)

Signed-off-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Acked-by: Matt Ranostay <matt.ranostay@konsulko.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  • Loading branch information
Peter Meerwald-Stadler authored and Jonathan Cameron committed Dec 2, 2017
1 parent c31c946 commit 7b0b0ec
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/iio/health/max30102.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,10 @@
#define MAX30102_REG_FIFO_CONFIG_AFULL BIT(0)

#define MAX30102_REG_MODE_CONFIG 0x09
#define MAX30102_REG_MODE_CONFIG_MODE_SPO2_EN BIT(0)
#define MAX30102_REG_MODE_CONFIG_MODE_HR_EN BIT(1)
#define MAX30102_REG_MODE_CONFIG_MODE_MASK 0x03
#define MAX30102_REG_MODE_CONFIG_MODE_HR 0x02 /* red LED */
#define MAX30102_REG_MODE_CONFIG_MODE_HR_SPO2 0x03 /* red + IR LED */
#define MAX30102_REG_MODE_CONFIG_MODE_MULTI 0x07 /* multi-LED mode */
#define MAX30102_REG_MODE_CONFIG_MODE_MASK GENMASK(2, 0)
#define MAX30102_REG_MODE_CONFIG_PWR BIT(7)

#define MAX30102_REG_SPO2_CONFIG 0x0a
Expand Down Expand Up @@ -287,11 +288,10 @@ static int max30102_chip_init(struct max30102_data *data)
if (ret)
return ret;

/* enable SPO2 mode */
/* enable HR + SPO2 mode */
ret = regmap_update_bits(data->regmap, MAX30102_REG_MODE_CONFIG,
MAX30102_REG_MODE_CONFIG_MODE_MASK,
MAX30102_REG_MODE_CONFIG_MODE_HR_EN |
MAX30102_REG_MODE_CONFIG_MODE_SPO2_EN);
MAX30102_REG_MODE_CONFIG_MODE_HR_SPO2);
if (ret)
return ret;

Expand Down

0 comments on commit 7b0b0ec

Please sign in to comment.