Skip to content

Commit

Permalink
PCI: layerscape: Pass device-specific struct to internal functions
Browse files Browse the repository at this point in the history
Only interfaces used from outside the driver, e.g., those called by the
DesignWare core, need to accept pointers to the generic struct pcie_port.
Internal interfaces can accept pointers to the device-specific struct,
which makes them more straightforward.  No functional change intended.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
  • Loading branch information
Bjorn Helgaas committed Oct 12, 2016
1 parent d41d295 commit 7b0b111
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/pci/host/pci-layerscape.c
Original file line number Diff line number Diff line change
@@ -213,12 +213,12 @@ static const struct of_device_id ls_pcie_of_match[] = {
{ },
};

static int __init ls_add_pcie_port(struct pcie_port *pp,
static int __init ls_add_pcie_port(struct ls_pcie *pcie,
struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct pcie_port *pp = &pcie->pp;
int ret;
struct ls_pcie *pcie = to_ls_pcie(pp);

pp->dev = dev;
pp->ops = pcie->drvdata->ops;
@@ -261,7 +261,7 @@ static int __init ls_pcie_probe(struct platform_device *pdev)
if (!ls_pcie_is_bridge(pcie))
return -ENODEV;

ret = ls_add_pcie_port(&pcie->pp, pdev);
ret = ls_add_pcie_port(pcie, pdev);
if (ret < 0)
return ret;

0 comments on commit 7b0b111

Please sign in to comment.