Skip to content

Commit

Permalink
clk: meson: remove obsolete comments
Browse files Browse the repository at this point in the history
Over time things changes in CCF and issues have been fixed in meson
controllers.

Now, clk81 is decently modeled by read-only PLLs, a mux, a divider
and a gate. We can remove the FIXME comments related to clk81.
Also remove the comment about devm_clk_hw_register, as there is
apparently nothing wrong with it.

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
  • Loading branch information
Jerome Brunet authored and Neil Armstrong committed Mar 13, 2018
1 parent 14bd7b9 commit 7b174c5
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 12 deletions.
5 changes: 0 additions & 5 deletions drivers/clk/meson/axg.c
Original file line number Diff line number Diff line change
Expand Up @@ -411,11 +411,6 @@ static struct meson_clk_mpll axg_mpll3 = {
},
};

/*
* FIXME The legacy composite clocks (e.g. clk81) are both PLL post-dividers
* and should be modeled with their respective PLLs via the forthcoming
* coordinated clock rates feature
*/
static u32 mux_table_clk81[] = { 0, 2, 3, 4, 5, 6, 7 };
static const char * const clk81_parent_names[] = {
"xtal", "fclk_div7", "mpll1", "mpll2", "fclk_div4",
Expand Down
6 changes: 0 additions & 6 deletions drivers/clk/meson/gxbb.c
Original file line number Diff line number Diff line change
Expand Up @@ -575,12 +575,6 @@ static struct meson_clk_mpll gxbb_mpll2 = {
},
};

/*
* FIXME The legacy composite clocks (e.g. clk81) are both PLL post-dividers
* and should be modeled with their respective PLLs via the forthcoming
* coordinated clock rates feature
*/

static u32 mux_table_clk81[] = { 0, 2, 3, 4, 5, 6, 7 };
static const char * const clk81_parent_names[] = {
"xtal", "fclk_div7", "mpll1", "mpll2", "fclk_div4",
Expand Down
1 change: 0 additions & 1 deletion drivers/clk/meson/meson8b.c
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,6 @@ static int meson8b_clkc_probe(struct platform_device *pdev)
if (!meson8b_hw_onecell_data.hws[i])
continue;

/* FIXME convert to devm_clk_register */
ret = devm_clk_hw_register(dev, meson8b_hw_onecell_data.hws[i]);
if (ret)
return ret;
Expand Down

0 comments on commit 7b174c5

Please sign in to comment.