Skip to content

Commit

Permalink
hwmon: (nct7904) Fix incorrect range of temperature limit registers
Browse files Browse the repository at this point in the history
The format of temperature limitation registers are 8-bit 2's complement
and the range is -128~127.
Converts the reading value to signed char to fix the incorrect range
of temperature limitation registers.

Signed-off-by: Amy Shih <amy.shih@advantech.com.tw>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
  • Loading branch information
Amy Shih authored and Guenter Roeck committed May 13, 2020
1 parent 6d44e43 commit 7b2fd27
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/hwmon/nct7904.c
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
struct nct7904_data *data = dev_get_drvdata(dev);
int ret, temp;
unsigned int reg1, reg2, reg3;
s8 temps;

switch (attr) {
case hwmon_temp_input:
Expand Down Expand Up @@ -467,7 +468,8 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,

if (ret < 0)
return ret;
*val = ret * 1000;
temps = ret;
*val = temps * 1000;
return 0;
}

Expand Down

0 comments on commit 7b2fd27

Please sign in to comment.