Skip to content

Commit

Permalink
staging: dgrp: check for a valid proc dir entry pointer
Browse files Browse the repository at this point in the history
while proc_create fails, the register_proc_table can do a derefernce of the
null pointer causing to oops the system, instead check for a valid pointer
at register and unregister

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Devendra Naga authored and Greg Kroah-Hartman committed Jan 22, 2013
1 parent b194218 commit 7b63c57
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/staging/dgrp/dgrp_specproc.c
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,13 @@ static struct dgrp_proc_entry dgrp_dpa_table[] = {

void dgrp_unregister_proc(void)
{
unregister_proc_table(dgrp_table, dgrp_proc_dir_entry);
net_entry_pointer = NULL;
mon_entry_pointer = NULL;
dpa_entry_pointer = NULL;
ports_entry_pointer = NULL;

if (dgrp_proc_dir_entry) {
unregister_proc_table(dgrp_table, dgrp_proc_dir_entry);
remove_proc_entry(dgrp_proc_dir_entry->name,
dgrp_proc_dir_entry->parent);
dgrp_proc_dir_entry = NULL;
Expand Down Expand Up @@ -231,6 +231,8 @@ static void register_proc_table(struct dgrp_proc_entry *table,

if (table == NULL)
return;
if (root == NULL)
return;

for (; table->id; table++) {
/* Can't do anything without a proc name. */
Expand Down

0 comments on commit 7b63c57

Please sign in to comment.