Skip to content

Commit

Permalink
regulator: palmas correct dt parsing
Browse files Browse the repository at this point in the history
Fix the DT parsing to agree with the bindings document. Some small changes
to the value names and also fix the handling of boolean values. They were
previously using prop = 1/0, now just use of_property_read_bool calls.

Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Graeme Gregory authored and Mark Brown committed Mar 8, 2013
1 parent 3c870e3 commit 7be859f
Showing 1 changed file with 20 additions and 16 deletions.
36 changes: 20 additions & 16 deletions drivers/regulator/palmas-regulator.c
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* Driver for Regulator part of Palmas PMIC Chips
*
* Copyright 2011-2012 Texas Instruments Inc.
* Copyright 2011-2013 Texas Instruments Inc.
*
* Author: Graeme Gregory <gg@slimlogic.co.uk>
*
Expand Down Expand Up @@ -552,15 +552,13 @@ static void palmas_dt_to_pdata(struct device *dev,
pdata->reg_init[idx] = devm_kzalloc(dev,
sizeof(struct palmas_reg_init), GFP_KERNEL);

ret = of_property_read_u32(palmas_matches[idx].of_node,
"ti,warm-reset", &prop);
if (!ret)
pdata->reg_init[idx]->warm_reset = prop;
pdata->reg_init[idx]->warm_reset =
of_property_read_u32(palmas_matches[idx].of_node,
"ti,warm-reset", &prop);

ret = of_property_read_u32(palmas_matches[idx].of_node,
"ti,roof-floor", &prop);
if (!ret)
pdata->reg_init[idx]->roof_floor = prop;
pdata->reg_init[idx]->roof_floor =
of_property_read_bool(palmas_matches[idx].of_node,
"ti,roof-floor");

ret = of_property_read_u32(palmas_matches[idx].of_node,
"ti,mode-sleep", &prop);
Expand All @@ -572,15 +570,14 @@ static void palmas_dt_to_pdata(struct device *dev,
if (!ret)
pdata->reg_init[idx]->tstep = prop;

ret = of_property_read_u32(palmas_matches[idx].of_node,
"ti,vsel", &prop);
if (!ret)
pdata->reg_init[idx]->vsel = prop;
ret = of_property_read_bool(palmas_matches[idx].of_node,
"ti,smps-range");
if (ret)
pdata->reg_init[idx]->vsel =
PALMAS_SMPS12_VOLTAGE_RANGE;
}

ret = of_property_read_u32(node, "ti,ldo6-vibrator", &prop);
if (!ret)
pdata->ldo6_vibrator = prop;
pdata->ldo6_vibrator = of_property_read_bool(node, "ti,ldo6-vibrator");
}


Expand Down Expand Up @@ -805,6 +802,13 @@ static int palmas_remove(struct platform_device *pdev)

static struct of_device_id of_palmas_match_tbl[] = {
{ .compatible = "ti,palmas-pmic", },
{ .compatible = "ti,palmas-charger-pmic", },
{ .compatible = "ti,twl6035-pmic", },
{ .compatible = "ti,twl6036-pmic", },
{ .compatible = "ti,twl6037-pmic", },
{ .compatible = "ti,tps65913-pmic", },
{ .compatible = "ti,tps65914-pmic", },
{ .compatible = "ti,tps80036-pmic", },
{ /* end */ }
};

Expand Down

0 comments on commit 7be859f

Please sign in to comment.