Skip to content

Commit

Permalink
sis190: mdio operation failure is not correctly detected
Browse files Browse the repository at this point in the history
i ranges from 0 to 100 in the 'for' loop a few lines above.

Reported by davem.

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Cc: K.M. Liu <kmliu@sis.com.tw>
  • Loading branch information
Francois Romieu authored and David S. Miller committed Jan 23, 2008
1 parent 11913d3 commit 7bf3f23
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/sis190.c
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ static void __mdio_cmd(void __iomem *ioaddr, u32 ctl)
msleep(1);
}

if (i > 999)
if (i > 99)
printk(KERN_ERR PFX "PHY command failed !\n");
}

Expand Down

0 comments on commit 7bf3f23

Please sign in to comment.