Skip to content

Commit

Permalink
powerpc: 'current_set' is now a table of task_struct pointers
Browse files Browse the repository at this point in the history
The table of pointers 'current_set' has been used for retrieving
the stack and current. They used to be thread_info pointers as
they were pointing to the stack and current was taken from the
'task' field of the thread_info.

Now, the pointers of 'current_set' table are now both pointers
to task_struct and pointers to thread_info.

As they are used to get current, and the stack pointer is
retrieved from current's stack field, this patch changes
their type to task_struct, and renames secondary_ti to
secondary_current.

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Christophe Leroy authored and Michael Ellerman committed Feb 23, 2019
1 parent a7916a1 commit 7c19c2e
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 15 deletions.
4 changes: 2 additions & 2 deletions arch/powerpc/include/asm/asm-prototypes.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
#include <uapi/asm/ucontext.h>

/* SMP */
extern struct thread_info *current_set[NR_CPUS];
extern struct thread_info *secondary_ti;
extern struct task_struct *current_set[NR_CPUS];
extern struct task_struct *secondary_current;
void start_secondary(void *unused);

/* kexec */
Expand Down
6 changes: 3 additions & 3 deletions arch/powerpc/kernel/head_32.S
Original file line number Diff line number Diff line change
Expand Up @@ -832,9 +832,9 @@ __secondary_start:
#endif /* CONFIG_PPC_BOOK3S_32 */

/* get current's stack and current */
lis r1,secondary_ti@ha
tophys(r1,r1)
lwz r2,secondary_ti@l(r1)
lis r2,secondary_current@ha
tophys(r2,r2)
lwz r2,secondary_current@l(r2)
tophys(r1,r2)
lwz r1,TASK_STACK(r1)

Expand Down
4 changes: 2 additions & 2 deletions arch/powerpc/kernel/head_44x.S
Original file line number Diff line number Diff line change
Expand Up @@ -1020,8 +1020,8 @@ _GLOBAL(start_secondary_47x)
/* Now we can get our task struct and real stack pointer */

/* Get current's stack and current */
lis r1,secondary_ti@ha
lwz r2,secondary_ti@l(r1)
lis r2,secondary_current@ha
lwz r2,secondary_current@l(r2)
lwz r1,TASK_STACK(r2)

/* Current stack pointer */
Expand Down
4 changes: 2 additions & 2 deletions arch/powerpc/kernel/head_fsl_booke.S
Original file line number Diff line number Diff line change
Expand Up @@ -1091,8 +1091,8 @@ __secondary_start:
bl call_setup_cpu

/* get current's stack and current */
lis r1,secondary_ti@ha
lwz r2,secondary_ti@l(r1)
lis r2,secondary_current@ha
lwz r2,secondary_current@l(r2)
lwz r1,TASK_STACK(r2)

/* stack */
Expand Down
10 changes: 4 additions & 6 deletions arch/powerpc/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
static DEFINE_PER_CPU(int, cpu_state) = { 0 };
#endif

struct thread_info *secondary_ti;
struct task_struct *secondary_current;
bool has_big_cores;

DEFINE_PER_CPU(cpumask_var_t, cpu_sibling_map);
Expand Down Expand Up @@ -631,7 +631,7 @@ void smp_send_stop(void)
}
#endif /* CONFIG_NMI_IPI */

struct thread_info *current_set[NR_CPUS];
struct task_struct *current_set[NR_CPUS];

static void smp_store_cpu_info(int id)
{
Expand Down Expand Up @@ -896,7 +896,7 @@ void smp_prepare_boot_cpu(void)
paca_ptrs[boot_cpuid]->__current = current;
#endif
set_numa_node(numa_cpu_lookup_table[boot_cpuid]);
current_set[boot_cpuid] = task_thread_info(current);
current_set[boot_cpuid] = current;
}

#ifdef CONFIG_HOTPLUG_CPU
Expand Down Expand Up @@ -981,15 +981,13 @@ static bool secondaries_inhibited(void)

static void cpu_idle_thread_init(unsigned int cpu, struct task_struct *idle)
{
struct thread_info *ti = task_thread_info(idle);

#ifdef CONFIG_PPC64
paca_ptrs[cpu]->__current = idle;
paca_ptrs[cpu]->kstack = (unsigned long)task_stack_page(idle) +
THREAD_SIZE - STACK_FRAME_OVERHEAD;
#endif
idle->cpu = cpu;
secondary_ti = current_set[cpu] = ti;
secondary_current = current_set[cpu] = idle;
}

int __cpu_up(unsigned int cpu, struct task_struct *tidle)
Expand Down

0 comments on commit 7c19c2e

Please sign in to comment.