Skip to content

Commit

Permalink
drivers: misc: Remove MISC_DEVICES config option
Browse files Browse the repository at this point in the history
MISC_DEVICES option alone does not select any kernel code and can cause dependency build warnings, such as:

warning: (KS8851 && AX88796_93CX6 && RTL8180 && RTL8187 && ADM8211 && RT2400PCI && RT2500PCI && RT61PCI && RT2800PCI && R8187SE) selects EEPROM_93CX6 which has unmet direct dependencies (MISC_DEVICES)

As the current drivers/misc/Kconfig stands, it is only possible to select the drivers below if MISC_DEVICES option is selected:

source "drivers/misc/c2port/Kconfig"
source "drivers/misc/eeprom/Kconfig"
source "drivers/misc/cb710/Kconfig"
source "drivers/misc/iwmc3200top/Kconfig"
source "drivers/misc/ti-st/Kconfig"
source "drivers/misc/lis3lv02d/Kconfig"
source "drivers/misc/carma/Kconfig"
source "drivers/misc/altera-stapl/Kconfig"

So remove MISC_DEVICES option so that nothing is dependant on it.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Fabio Estevam authored and Greg Kroah-Hartman committed Jan 25, 2012
1 parent ecd9d34 commit 7c5763b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 16 deletions.
17 changes: 3 additions & 14 deletions drivers/misc/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,14 @@
# Misc strange devices
#

# This one has to live outside of the MISC_DEVICES conditional,
# because it may be selected by drivers/platform/x86/hp_accel.
menu "Misc devices"

config SENSORS_LIS3LV02D
tristate
depends on INPUT
select INPUT_POLLDEV
default n

menuconfig MISC_DEVICES
bool "Misc devices"
---help---
Say Y here to get to see options for device drivers from various
different categories. This option alone does not add any kernel code.

If you say N, all options in this submenu will be skipped and disabled.

if MISC_DEVICES

config AD525X_DPOT
tristate "Analog Devices Digital Potentiometers"
depends on (I2C || SPI) && SYSFS
Expand Down Expand Up @@ -516,5 +506,4 @@ source "drivers/misc/ti-st/Kconfig"
source "drivers/misc/lis3lv02d/Kconfig"
source "drivers/misc/carma/Kconfig"
source "drivers/misc/altera-stapl/Kconfig"

endif # MISC_DEVICES
endmenu
1 change: 0 additions & 1 deletion drivers/mmc/host/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,6 @@ config MMC_SDHI
config MMC_CB710
tristate "ENE CB710 MMC/SD Interface support"
depends on PCI
select MISC_DEVICES
select CB710_CORE
help
This option enables support for MMC/SD part of ENE CB710/720 Flash
Expand Down
1 change: 0 additions & 1 deletion drivers/net/ethernet/micrel/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ config KS8851
select NET_CORE
select MII
select CRC32
select MISC_DEVICES
select EEPROM_93CX6
---help---
SPI driver for Micrel KS8851 SPI attached network chip.
Expand Down

0 comments on commit 7c5763b

Please sign in to comment.