Skip to content

Commit

Permalink
IPVS: precedence bug in ip_vs_sync_switch_mode()
Browse files Browse the repository at this point in the history
'!' has higher precedence than '&'.  IP_VS_STATE_MASTER is 0x1 so
the original code is equivelent to if (!ipvs->sync_state) ...

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Hans Schillstrom <hans.schillstrom@ericsson.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
  • Loading branch information
Dan Carpenter authored and Simon Horman committed Feb 7, 2011
1 parent 8525d6f commit 7c9989a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/netfilter/ipvs/ip_vs_sync.c
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ void ip_vs_sync_switch_mode(struct net *net, int mode)
{
struct netns_ipvs *ipvs = net_ipvs(net);

if (!ipvs->sync_state & IP_VS_STATE_MASTER)
if (!(ipvs->sync_state & IP_VS_STATE_MASTER))
return;
if (mode == ipvs->sysctl_sync_ver || !ipvs->sync_buff)
return;
Expand Down

0 comments on commit 7c9989a

Please sign in to comment.