Skip to content

Commit

Permalink
mwifiex: don't pretend to resume while remove()'ing
Browse files Browse the repository at this point in the history
The device core will not allow suspend() to race with remove().

Signed-off-by: Brian Norris <briannorris@chromium.org>
Tested-by: Xinming Hu <huxm@marvell.com>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
  • Loading branch information
Brian Norris authored and Kalle Valo committed Nov 19, 2016
1 parent a1beec4 commit 7ccdf72
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 13 deletions.
5 changes: 0 additions & 5 deletions drivers/net/wireless/marvell/mwifiex/pcie.c
Original file line number Diff line number Diff line change
Expand Up @@ -251,11 +251,6 @@ static void mwifiex_pcie_remove(struct pci_dev *pdev)
return;

if (user_rmmod && !adapter->mfg_mode) {
#ifdef CONFIG_PM_SLEEP
if (adapter->is_suspended)
mwifiex_pcie_resume(&pdev->dev);
#endif

mwifiex_deauthenticate_all(adapter);

priv = mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
Expand Down
3 changes: 0 additions & 3 deletions drivers/net/wireless/marvell/mwifiex/sdio.c
Original file line number Diff line number Diff line change
Expand Up @@ -244,9 +244,6 @@ mwifiex_sdio_remove(struct sdio_func *func)
mwifiex_dbg(adapter, INFO, "info: SDIO func num=%d\n", func->num);

if (user_rmmod && !adapter->mfg_mode) {
if (adapter->is_suspended)
mwifiex_sdio_resume(adapter->dev);

mwifiex_deauthenticate_all(adapter);

priv = mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
Expand Down
5 changes: 0 additions & 5 deletions drivers/net/wireless/marvell/mwifiex/usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -614,11 +614,6 @@ static void mwifiex_usb_disconnect(struct usb_interface *intf)
return;

if (user_rmmod && !adapter->mfg_mode) {
#ifdef CONFIG_PM
if (adapter->is_suspended)
mwifiex_usb_resume(intf);
#endif

mwifiex_deauthenticate_all(adapter);

mwifiex_init_shutdown_fw(mwifiex_get_priv(adapter,
Expand Down

0 comments on commit 7ccdf72

Please sign in to comment.