Skip to content

Commit

Permalink
bridge: multicast: start querier timer when running user-space stp
Browse files Browse the repository at this point in the history
When STP is running in user-space and querier is configured, the
querier timer is not started when a port goes to a non-blocking state.
This patch unifies the user- and kernel-space stp multicast port enable
path and enables it in all states different from blocking. Note that when a
port goes in BR_STATE_DISABLED it's not enabled because that is handled
in the beginning of the port list loop.

Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Nikolay Aleksandrov authored and David S. Miller committed Jun 23, 2015
1 parent b1dfe0a commit 7ce42de
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion net/bridge/br_stp.c
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,6 @@ static void br_make_forwarding(struct net_bridge_port *p)
else
br_set_state(p, BR_STATE_LEARNING);

br_multicast_enable_port(p);
br_log_state(p);
br_ifinfo_notify(RTM_NEWLINK, p);

Expand Down Expand Up @@ -462,6 +461,8 @@ void br_port_state_selection(struct net_bridge *br)
}
}

if (p->state != BR_STATE_BLOCKING)
br_multicast_enable_port(p);
if (p->state == BR_STATE_FORWARDING)
++liveports;
}
Expand Down

0 comments on commit 7ce42de

Please sign in to comment.