Skip to content

Commit

Permalink
crypto: atmel-tdes - Remove useless write in Control Register
Browse files Browse the repository at this point in the history
As claimed by the datasheet, writing 0 into the Control Register has no
effect. Remove this useless register access.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Tudor Ambarus authored and Herbert Xu committed Dec 11, 2019
1 parent e783651 commit 7d0979e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/crypto/atmel-tdes.c
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ static void atmel_tdes_dma_callback(void *data)
static int atmel_tdes_write_ctrl(struct atmel_tdes_dev *dd)
{
int err;
u32 valcr = 0, valmr = TDES_MR_SMOD_PDC;
u32 valmr = TDES_MR_SMOD_PDC;

err = atmel_tdes_hw_init(dd);

Expand Down Expand Up @@ -307,7 +307,6 @@ static int atmel_tdes_write_ctrl(struct atmel_tdes_dev *dd)
if ((dd->flags & TDES_FLAGS_ENCRYPT) || (dd->flags & TDES_FLAGS_OFB))
valmr |= TDES_MR_CYPHER_ENC;

atmel_tdes_write(dd, TDES_CR, valcr);
atmel_tdes_write(dd, TDES_MR, valmr);

atmel_tdes_write_n(dd, TDES_KEY1W1R, dd->ctx->key,
Expand Down

0 comments on commit 7d0979e

Please sign in to comment.