Skip to content

Commit

Permalink
drm/fbdev-client: Unexport drm_fbdev_client_setup()
Browse files Browse the repository at this point in the history
DRM drivers invoke drm_client_setup() to set up in-kernel clients.
No driver should call drm_fbdev_client_setup() directly. Therefore,
unexport the symbol and move the declaration to the internal header
drm_client_internal.h.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241108154600.126162-4-tzimmermann@suse.de
  • Loading branch information
Thomas Zimmermann committed Nov 15, 2024
1 parent b86711c commit 7d2faa8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* SPDX-License-Identifier: MIT */

#ifndef DRM_FBDEV_CLIENT_H
#define DRM_FBDEV_CLIENT_H
#ifndef DRM_CLIENT_INTERNAL_H
#define DRM_CLIENT_INTERNAL_H

struct drm_device;
struct drm_format_info;
Expand Down
3 changes: 2 additions & 1 deletion drivers/gpu/drm/clients/drm_client_setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@

#include <drm/clients/drm_client_setup.h>
#include <drm/drm_device.h>
#include <drm/drm_fbdev_client.h>
#include <drm/drm_fourcc.h>
#include <drm/drm_print.h>

#include "drm_client_internal.h"

/**
* drm_client_setup() - Setup in-kernel DRM clients
* @dev: DRM device
Expand Down
4 changes: 2 additions & 2 deletions drivers/gpu/drm/clients/drm_fbdev_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@
#include <drm/drm_client.h>
#include <drm/drm_crtc_helper.h>
#include <drm/drm_drv.h>
#include <drm/drm_fbdev_client.h>
#include <drm/drm_fb_helper.h>
#include <drm/drm_fourcc.h>
#include <drm/drm_print.h>

#include "drm_client_internal.h"

/*
* struct drm_client_funcs
*/
Expand Down Expand Up @@ -164,4 +165,3 @@ int drm_fbdev_client_setup(struct drm_device *dev, const struct drm_format_info
kfree(fb_helper);
return ret;
}
EXPORT_SYMBOL(drm_fbdev_client_setup);

0 comments on commit 7d2faa8

Please sign in to comment.