Skip to content

Commit

Permalink
pinctrl: at91: Merge clk_prepare and clk_enable into clk_prepare_enable
Browse files Browse the repository at this point in the history
This simplifies the normal as well as the error path.

Signed-off-by: Alexander Stein <alexanders83@web.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Alexander Stein authored and Linus Walleij committed May 2, 2016
1 parent 234b651 commit 7d3a3fe
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions drivers/pinctrl/pinctrl-at91.c
Original file line number Diff line number Diff line change
Expand Up @@ -1722,14 +1722,9 @@ static int at91_gpio_probe(struct platform_device *pdev)
goto err;
}

ret = clk_prepare(at91_chip->clock);
if (ret)
goto clk_prepare_err;

/* enable PIO controller's clock */
ret = clk_enable(at91_chip->clock);
ret = clk_prepare_enable(at91_chip->clock);
if (ret) {
dev_err(&pdev->dev, "failed to enable clock, ignoring.\n");
dev_err(&pdev->dev, "failed to prepare and enable clock, ignoring.\n");
goto clk_enable_err;
}

Expand Down Expand Up @@ -1789,10 +1784,8 @@ static int at91_gpio_probe(struct platform_device *pdev)
irq_setup_err:
gpiochip_remove(chip);
gpiochip_add_err:
clk_disable(at91_chip->clock);
clk_enable_err:
clk_unprepare(at91_chip->clock);
clk_prepare_err:
clk_disable_unprepare(at91_chip->clock);
err:
dev_err(&pdev->dev, "Failure %i for GPIO %i\n", ret, alias_idx);

Expand Down

0 comments on commit 7d3a3fe

Please sign in to comment.