Skip to content

Commit

Permalink
perf llvm: Don't access out-of-scope array
Browse files Browse the repository at this point in the history
The 'test_dir' variable is assigned to the 'release' array which is
out-of-scope 3 lines later.

Extend the scope of the 'release' array so that an out-of-scope array
isn't accessed.

Bug detected by clang's address sanitizer.

Fixes: 07bc5c6 ("perf tools: Make fetch_kernel_version() publicly available")
Cc: stable@vger.kernel.org # v4.4+
Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lore.kernel.org/lkml/20190926220018.25402-1-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Ian Rogers authored and Arnaldo Carvalho de Melo committed Sep 30, 2019
1 parent b7ad610 commit 7d4c85b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tools/perf/util/llvm-utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -233,14 +233,14 @@ static int detect_kbuild_dir(char **kbuild_dir)
const char *prefix_dir = "";
const char *suffix_dir = "";

/* _UTSNAME_LENGTH is 65 */
char release[128];

char *autoconf_path;

int err;

if (!test_dir) {
/* _UTSNAME_LENGTH is 65 */
char release[128];

err = fetch_kernel_version(NULL, release,
sizeof(release));
if (err)
Expand Down

0 comments on commit 7d4c85b

Please sign in to comment.