Skip to content

Commit

Permalink
staging: rtl8723bs: Remove rtw_btcoex_SetManualControl()
Browse files Browse the repository at this point in the history
Remove function rtw_btcoex_SetManualControl as all it does is call
hal_btcoex_SetManualControl.
Modify call sites accordingly.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Nishka Dasgupta authored and Greg Kroah-Hartman committed Jul 1, 2019
1 parent 800132a commit 7d6a6e7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
5 changes: 0 additions & 5 deletions drivers/staging/rtl8723bs/core/rtw_btcoex.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,6 @@ s32 rtw_btcoex_IsBTCoexCtrlAMPDUSize(struct adapter *padapter)
return coexctrl;
}

void rtw_btcoex_SetManualControl(struct adapter *padapter, u8 manual)
{
hal_btcoex_SetManualControl(padapter, manual);
}

u8 rtw_btcoex_IsBtControlLps(struct adapter *padapter)
{
return hal_btcoex_IsBtControlLps(padapter);
Expand Down
1 change: 0 additions & 1 deletion drivers/staging/rtl8723bs/include/rtw_btcoex.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ void rtw_btcoex_HaltNotify(struct adapter *);
u8 rtw_btcoex_IsBtDisabled(struct adapter *);
void rtw_btcoex_Handler(struct adapter *);
s32 rtw_btcoex_IsBTCoexCtrlAMPDUSize(struct adapter *);
void rtw_btcoex_SetManualControl(struct adapter *, u8 bmanual);
u8 rtw_btcoex_IsBtControlLps(struct adapter *);
u8 rtw_btcoex_IsLpsOn(struct adapter *);
u8 rtw_btcoex_RpwmVal(struct adapter *);
Expand Down
5 changes: 3 additions & 2 deletions drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include <drv_types.h>
#include <rtw_debug.h>
#include <rtw_mp.h>
#include <hal_btcoex.h>
#include <linux/jiffies.h>
#include <linux/kernel.h>

Expand Down Expand Up @@ -4536,10 +4537,10 @@ static int rtw_test(
}

if (strcmp(pch, "bton") == 0)
rtw_btcoex_SetManualControl(padapter, false);
hal_btcoex_SetManualControl(padapter, false);

if (strcmp(pch, "btoff") == 0)
rtw_btcoex_SetManualControl(padapter, true);
hal_btcoex_SetManualControl(padapter, true);

if (strcmp(pch, "h2c") == 0) {
u8 param[8];
Expand Down

0 comments on commit 7d6a6e7

Please sign in to comment.