Skip to content

Commit

Permalink
cuda/pmu: Make find_via_cuda/pmu init functions
Browse files Browse the repository at this point in the history
Make `find_via_cuda` and `find_via_pmu` initialization functions.
Previously, their definitions in `drivers/macintosh/via-cuda.h` include
the `__init` attribute but their alternative definitions in
`arch/powerpc/powermac/sectup./c` and prototypes in `include/linux/
cuda.h` and `include/linux/pmu.h` do not use the `__init` macro. Since,
only initialization functions call `find_via_cuda` and `find_via_pmu`
it is safe to label these functions with `__init`.

Signed-off-by: Nick Child <nick.child@ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20211216220035.605465-21-nick.child@ibm.com
  • Loading branch information
Nick Child authored and Michael Ellerman committed Dec 23, 2021
1 parent 2493a24 commit 7da1d1d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions arch/powerpc/platforms/powermac/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ static void pmac_show_cpuinfo(struct seq_file *m)
}

#ifndef CONFIG_ADB_CUDA
int find_via_cuda(void)
int __init find_via_cuda(void)
{
struct device_node *dn = of_find_node_by_name(NULL, "via-cuda");

Expand All @@ -180,7 +180,7 @@ int find_via_cuda(void)
#endif

#ifndef CONFIG_ADB_PMU
int find_via_pmu(void)
int __init find_via_pmu(void)
{
struct device_node *dn = of_find_node_by_name(NULL, "via-pmu");

Expand Down
2 changes: 1 addition & 1 deletion include/linux/cuda.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#include <uapi/linux/cuda.h>


extern int find_via_cuda(void);
extern int __init find_via_cuda(void);
extern int cuda_request(struct adb_request *req,
void (*done)(struct adb_request *), int nbytes, ...);
extern void cuda_poll(void);
Expand Down
2 changes: 1 addition & 1 deletion include/linux/pmu.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include <uapi/linux/pmu.h>


extern int find_via_pmu(void);
extern int __init find_via_pmu(void);

extern int pmu_request(struct adb_request *req,
void (*done)(struct adb_request *), int nbytes, ...);
Expand Down

0 comments on commit 7da1d1d

Please sign in to comment.