Skip to content

Commit

Permalink
spi: intel: Remove DANGEROUS tag from pci driver
Browse files Browse the repository at this point in the history
Modern CPUs exposes this controller as PCI device that only uses
hardware sequencing capabilities which is safer than software
sequencing.
Leave the platform driver as *DANGEROUS* and update help text since
most of these controllers are using software sequencing.

Signed-off-by: Mauro Lima <mauro.lima@eclypsium.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://lore.kernel.org/r/20230206183143.75274-2-mauro.lima@eclypsium.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Mauro Lima authored and Mark Brown committed Feb 7, 2023
1 parent 9418119 commit 7db738b
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions drivers/spi/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -447,16 +447,17 @@ config SPI_INTEL
tristate

config SPI_INTEL_PCI
tristate "Intel PCH/PCU SPI flash PCI driver (DANGEROUS)"
tristate "Intel PCH/PCU SPI flash PCI driver"
depends on PCI
depends on X86 || COMPILE_TEST
depends on SPI_MEM
select SPI_INTEL
help
This enables PCI support for the Intel PCH/PCU SPI controller in
master mode. This controller is present in modern Intel hardware
and is used to hold BIOS and other persistent settings. Using
this driver it is possible to upgrade BIOS directly from Linux.
and is used to hold BIOS and other persistent settings. This
driver only supports hardware sequencing mode. Using this
driver it is possible to upgrade BIOS directly from Linux.

Say N here unless you know what you are doing. Overwriting the
SPI flash may render the system unbootable.
Expand All @@ -471,10 +472,10 @@ config SPI_INTEL_PLATFORM
select SPI_INTEL
help
This enables platform support for the Intel PCH/PCU SPI
controller in master mode. This controller is present in modern
Intel hardware and is used to hold BIOS and other persistent
settings. Using this driver it is possible to upgrade BIOS
directly from Linux.
controller in master mode that is used to hold BIOS and other
persistent settings. Most of these controllers are using
software sequencing mode. Using this driver it is possible to
upgrade BIOS directly from Linux.

Say N here unless you know what you are doing. Overwriting the
SPI flash may render the system unbootable.
Expand Down

0 comments on commit 7db738b

Please sign in to comment.