Skip to content

Commit

Permalink
netfilter: x_tables: unlock on error in xt_find_table_lock()
Browse files Browse the repository at this point in the history
According to my static checker we should unlock here before the return.
That seems reasonable to me as well.

Fixes" b9e69e1 ("netfilter: xtables: don't hook tables by default")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
  • Loading branch information
Dan Carpenter authored and Pablo Neira Ayuso committed Apr 28, 2017
1 parent 9dd2ab6 commit 7dde07e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion net/netfilter/x_tables.c
Original file line number Diff line number Diff line change
Expand Up @@ -1051,8 +1051,10 @@ struct xt_table *xt_find_table_lock(struct net *net, u_int8_t af,
list_for_each_entry(t, &init_net.xt.tables[af], list) {
if (strcmp(t->name, name))
continue;
if (!try_module_get(t->me))
if (!try_module_get(t->me)) {
mutex_unlock(&xt[af].mutex);
return NULL;
}

mutex_unlock(&xt[af].mutex);
if (t->table_init(net) != 0) {
Expand Down

0 comments on commit 7dde07e

Please sign in to comment.