Skip to content

Commit

Permalink
regulator: core: Don't terminate supply resolution early
Browse files Browse the repository at this point in the history
The function regulator_register_resolve_supply() is called from the
context of class_for_each_dev() (during the regulator registration) to
resolve any supplies added. regulator_register_resolve_supply() will
return an error if a regulator's supply cannot be resolved and this will
terminate the loop in class_for_each_dev(). This means that we will not
attempt to resolve any other supplies after one has failed. Hence, this
may delay the resolution of other regulator supplies until the failing
one itself can be resolved.

Rather than terminating the loop early, don't return an error code and
keep attempting to resolve any other supplies for regulators that have
been registered.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Jon Hunter authored and Mark Brown committed Apr 22, 2016
1 parent a215137 commit 7ddede6
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion drivers/regulator/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -3842,7 +3842,12 @@ static void rdev_init_debugfs(struct regulator_dev *rdev)

static int regulator_register_resolve_supply(struct device *dev, void *data)
{
return regulator_resolve_supply(dev_to_rdev(dev));
struct regulator_dev *rdev = dev_to_rdev(dev);

if (regulator_resolve_supply(rdev))
rdev_dbg(rdev, "unable to resolve supply\n");

return 0;
}

/**
Expand Down

0 comments on commit 7ddede6

Please sign in to comment.