Skip to content

Commit

Permalink
[ARM] pxa: ensure mfp is in correct range in mfp_{read,write}
Browse files Browse the repository at this point in the history
Ensure we do not read/write outside array boundaries with a negative index.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
  • Loading branch information
Roel Kluin authored and Eric Miao committed Nov 16, 2009
1 parent 10d5d99 commit 7df56c2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/arm/plat-pxa/mfp.c
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ unsigned long mfp_read(int mfp)
{
unsigned long val, flags;

BUG_ON(mfp >= MFP_PIN_MAX);
BUG_ON(mfp < 0 || mfp >= MFP_PIN_MAX);

spin_lock_irqsave(&mfp_spin_lock, flags);
val = mfpr_readl(mfp_table[mfp].mfpr_off);
Expand All @@ -220,7 +220,7 @@ void mfp_write(int mfp, unsigned long val)
{
unsigned long flags;

BUG_ON(mfp >= MFP_PIN_MAX);
BUG_ON(mfp < 0 || mfp >= MFP_PIN_MAX);

spin_lock_irqsave(&mfp_spin_lock, flags);
mfpr_writel(mfp_table[mfp].mfpr_off, val);
Expand Down

0 comments on commit 7df56c2

Please sign in to comment.