Skip to content

Commit

Permalink
tty: serial: kgdboc: use srcu console list iterator
Browse files Browse the repository at this point in the history
Use srcu console list iteration for safe console list traversal.
Note that this is a preparatory change for when console_lock no
longer provides synchronization for the console list.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20221116162152.193147-36-john.ogness@linutronix.de
  • Loading branch information
John Ogness authored and Petr Mladek committed Dec 2, 2022
1 parent 28de287 commit 7e537af
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions drivers/tty/serial/kgdboc.c
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,7 @@ static void kgdboc_earlycon_pre_exp_handler(void)
{
struct console *con;
static bool already_warned;
int cookie;

if (already_warned)
return;
Expand All @@ -463,9 +464,14 @@ static void kgdboc_earlycon_pre_exp_handler(void)
* serial drivers might be OK with this, print a warning once per
* boot if we detect this case.
*/
for_each_console(con)
cookie = console_srcu_read_lock();
for_each_console_srcu(con) {
if (con == kgdboc_earlycon_io_ops.cons)
return;
break;
}
console_srcu_read_unlock(cookie);
if (con)
return;

already_warned = true;
pr_warn("kgdboc_earlycon is still using bootconsole\n");
Expand Down

0 comments on commit 7e537af

Please sign in to comment.