Skip to content

Commit

Permalink
HID: introduce proper dependency of HID_BATTERY on POWER_SUPPLY
Browse files Browse the repository at this point in the history
ppc6xx_defconfig reveals this:

drivers/built-in.o: In function `hidinput_cleanup_battery': drivers/hid/hid-input.c:351: undefined reference to`power_supply_unregister'
drivers/built-in.o: In function `hidinput_setup_battery': drivers/hid/hid-input.c:338: undefined reference to `power_supply_register'
make[1]: *** [.tmp_vmlinux1] Error 1

The defconfig in question doens't mention either option and kbuild is
genertaing

	CONFIG_HID_BATTERY_STRENGTH=y
	CONFIG_POWER_SUPPLY=m

which is wrong. Put a proper dependency in place.

Reported-by: Tony Breeds <tony@bakeyournoodle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Jiri Kosina committed Dec 16, 2011
1 parent 8c3d52f commit 7e69ba7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/hid/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ config HID

config HID_BATTERY_STRENGTH
bool
depends on POWER_SUPPLY
depends on HID && POWER_SUPPLY && HID == POWER_SUPPLY
default y

config HIDRAW
Expand Down

0 comments on commit 7e69ba7

Please sign in to comment.