Skip to content

Commit

Permalink
clk: qcom: gcc-sm8550: use collapse-voting for PCIe GDSCs
Browse files Browse the repository at this point in the history
The PCIe GDSCs can be shared with other masters and should use the APCS
collapse-vote register when updating the power state.

This is specifically also needed to be able to disable power domains
that have been enabled by boot firmware using the vote register.

Following other recent Qualcomm platforms, describe this register and
the corresponding mask for the PCIe (and _phy) GDSCs.

Fixes: 955f2ea ("clk: qcom: Add GCC driver for SM8550")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20231218-topic-8550_fixes-v1-5-ce1272d77540@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
  • Loading branch information
Konrad Dybcio authored and Bjorn Andersson committed Dec 19, 2023
1 parent e7fe73f commit 7e77a39
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions drivers/clk/qcom/gcc-sm8550.c
Original file line number Diff line number Diff line change
Expand Up @@ -2998,6 +2998,8 @@ static struct clk_branch gcc_video_axi1_clk = {

static struct gdsc pcie_0_gdsc = {
.gdscr = 0x6b004,
.collapse_ctrl = 0x52020,
.collapse_mask = BIT(0),
.pd = {
.name = "pcie_0_gdsc",
},
Expand All @@ -3007,6 +3009,8 @@ static struct gdsc pcie_0_gdsc = {

static struct gdsc pcie_0_phy_gdsc = {
.gdscr = 0x6c000,
.collapse_ctrl = 0x52020,
.collapse_mask = BIT(3),
.pd = {
.name = "pcie_0_phy_gdsc",
},
Expand All @@ -3016,6 +3020,8 @@ static struct gdsc pcie_0_phy_gdsc = {

static struct gdsc pcie_1_gdsc = {
.gdscr = 0x8d004,
.collapse_ctrl = 0x52020,
.collapse_mask = BIT(1),
.pd = {
.name = "pcie_1_gdsc",
},
Expand All @@ -3025,6 +3031,8 @@ static struct gdsc pcie_1_gdsc = {

static struct gdsc pcie_1_phy_gdsc = {
.gdscr = 0x8e000,
.collapse_ctrl = 0x52020,
.collapse_mask = BIT(4),
.pd = {
.name = "pcie_1_phy_gdsc",
},
Expand Down

0 comments on commit 7e77a39

Please sign in to comment.