Skip to content

Commit

Permalink
staging: bcm2835-camera: Remove explicit cache flush operations
Browse files Browse the repository at this point in the history
The camera code has an explicit cache flush operation
which is not portable.  Now that vc04_services is using portable
DMA APIs that already do the cache flushing, explicit flushes
should no longer be needed.

The one call to __cpuc_flush_dcache_area has been removed.

Testing:
	The offical V2 camera for the RPI was tested on a RPI 3
	running in 32 bit mode(armhf).  The cheese application
	and ffmpeg was used to view and stream video from the
	camera.  Nothing new seems to be broken without the
	cache flushing.

Signed-off-by: Michael Zoran <mzoran@crowfest.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Michael Zoran authored and Greg Kroah-Hartman committed Mar 8, 2017
1 parent 5b6d458 commit 7e8dbea
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
Original file line number Diff line number Diff line change
Expand Up @@ -276,10 +276,6 @@ static int bulk_receive(struct vchiq_mmal_instance *instance,
msg_context->u.bulk.dts = msg->u.buffer_from_host.buffer_header.dts;
msg_context->u.bulk.pts = msg->u.buffer_from_host.buffer_header.pts;

// only need to flush L1 cache here, as VCHIQ takes care of the L2
// cache.
__cpuc_flush_dcache_area(msg_context->u.bulk.buffer->buffer, rd_len);

/* queue the bulk submission */
vchi_service_use(instance->handle);
ret = vchi_bulk_queue_receive(instance->handle,
Expand Down

0 comments on commit 7e8dbea

Please sign in to comment.