Skip to content

Commit

Permalink
gpio: 74x164: Introduce 'enable-gpios' property
Browse files Browse the repository at this point in the history
74HC595 has an /OE (output enable) pin that can be controlled by a GPIO.

Introduce an optional property called 'enable-gpios' that allows
controlling the /OE pin.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Fabio Estevam authored and Linus Walleij committed Aug 14, 2017
1 parent ee949b5 commit 7ebc194
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Documentation/devicetree/bindings/gpio/gpio-74x164.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ Required properties:
1 = active low
- registers-number: Number of daisy-chained shift registers

Optional properties:
- enable-gpios: GPIO connected to the OE (Output Enable) pin.

Example:

gpio5: gpio5@0 {
Expand Down
10 changes: 10 additions & 0 deletions drivers/gpio/gpio-74x164.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* published by the Free Software Foundation.
*/

#include <linux/gpio/consumer.h>
#include <linux/init.h>
#include <linux/mutex.h>
#include <linux/spi/spi.h>
Expand All @@ -31,6 +32,7 @@ struct gen_74x164_chip {
* numbering, store the bytes in reverse order.
*/
u8 buffer[0];
struct gpio_desc *gpiod_oe;
};

static int __gen_74x164_write_config(struct gen_74x164_chip *chip)
Expand Down Expand Up @@ -126,6 +128,13 @@ static int gen_74x164_probe(struct spi_device *spi)
if (!chip)
return -ENOMEM;

chip->gpiod_oe = devm_gpiod_get_optional(&spi->dev, "enable",
GPIOD_OUT_LOW);
if (IS_ERR(chip->gpiod_oe))
return PTR_ERR(chip->gpiod_oe);

gpiod_set_value_cansleep(chip->gpiod_oe, 1);

spi_set_drvdata(spi, chip);

chip->gpio_chip.label = spi->modalias;
Expand Down Expand Up @@ -164,6 +173,7 @@ static int gen_74x164_remove(struct spi_device *spi)
{
struct gen_74x164_chip *chip = spi_get_drvdata(spi);

gpiod_set_value_cansleep(chip->gpiod_oe, 0);
gpiochip_remove(&chip->gpio_chip);
mutex_destroy(&chip->lock);

Expand Down

0 comments on commit 7ebc194

Please sign in to comment.