Skip to content

Commit

Permalink
MIPS: PCI: Remove unused busn_offset
Browse files Browse the repository at this point in the history
pci_add_resource_offset() is for host bridge windows where the bridge
translates CPU addresses to PCI bus addresses by adding an offset.  To my
knowledge, no host bridge translates bus numbers, so this is only useful
for MEM and IO windows.  In any event, host->busn_offset is never set to
anything other than zero, so pci_add_resource() is sufficient.

a2e50f5 ("MIPS: PCI: Add a hook for IORESOURCE_BUS in
pci_controller/bridge_controller") also added busn_resource itself.  This
is currently unused but may be used by future SGI IP27 fixes, so I left it
there.

Tested-by: Joshua Kinard <kumba@gentoo.org>	# SGI IP30 and IP27
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Joshua Kinard <kumba@gentoo.org>
  • Loading branch information
Bjorn Helgaas committed May 18, 2017
1 parent f5853e8 commit 7ee214b
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion arch/mips/include/asm/pci.h
Original file line number Diff line number Diff line change
@@ -39,7 +39,6 @@ struct pci_controller {
unsigned long io_offset;
unsigned long io_map_base;
struct resource *busn_resource;
unsigned long busn_offset;

#ifndef CONFIG_PCI_DOMAINS_GENERIC
unsigned int index;
3 changes: 1 addition & 2 deletions arch/mips/pci/pci-legacy.c
Original file line number Diff line number Diff line change
@@ -86,8 +86,7 @@ static void pcibios_scanbus(struct pci_controller *hose)
hose->mem_resource, hose->mem_offset);
pci_add_resource_offset(&resources,
hose->io_resource, hose->io_offset);
pci_add_resource_offset(&resources,
hose->busn_resource, hose->busn_offset);
pci_add_resource(&resources, hose->busn_resource);
bus = pci_scan_root_bus(NULL, next_busno, hose->pci_ops, hose,
&resources);
hose->bus = bus;

0 comments on commit 7ee214b

Please sign in to comment.