Skip to content

Commit

Permalink
pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08_irq()
Browse files Browse the repository at this point in the history
commit 884af72 upstream.

Add the missing unlock before return from function mcp23s08_irq()
in the error handling case.

v1-->v2:
   remove the "return IRQ_HANDLED" line

Fixes: 897120d ("pinctrl: mcp23s08: fix race condition in irq handler")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Link: https://lore.kernel.org/r/1623134048-56051-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Zou Wei authored and Greg Kroah-Hartman committed Jul 19, 2021
1 parent e294f97 commit 7eefc57
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/pinctrl/pinctrl-mcp23s08.c
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ static irqreturn_t mcp23s08_irq(int irq, void *data)

if (intf == 0) {
/* There is no interrupt pending */
return IRQ_HANDLED;
goto unlock;
}

if (mcp_read(mcp, MCP_INTCAP, &intcap))
Expand Down

0 comments on commit 7eefc57

Please sign in to comment.