Skip to content

Commit

Permalink
ethtool: thunder_bgx: use ethtool.h constants for speed and duplex
Browse files Browse the repository at this point in the history
Use constants provided by ethtool.h for speed and duplex values
instead of raw integer constants to increase code readability.

thunder_bgx already uses SPEED_UNKNOWN and DUPLEX_UNKNOWN constants,
also provided by ethtool.h.

Signed-off-by: Michael Zhivich <mzhivich@akamai.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Michael Zhivich authored and David S. Miller committed Apr 8, 2019
1 parent b7f29f8 commit 7f301cf
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/net/ethernet/cavium/thunder/thunder_bgx.c
Original file line number Diff line number Diff line change
Expand Up @@ -962,13 +962,13 @@ static void bgx_poll_for_sgmii_link(struct lmac *lmac)
lmac->last_duplex = (an_result >> 1) & 0x1;
switch (speed) {
case 0:
lmac->last_speed = 10;
lmac->last_speed = SPEED_10;
break;
case 1:
lmac->last_speed = 100;
lmac->last_speed = SPEED_100;
break;
case 2:
lmac->last_speed = 1000;
lmac->last_speed = SPEED_1000;
break;
default:
lmac->link_up = false;
Expand Down Expand Up @@ -1012,10 +1012,10 @@ static void bgx_poll_for_link(struct work_struct *work)
!(smu_link & SMU_RX_CTL_STATUS)) {
lmac->link_up = 1;
if (lmac->lmac_type == BGX_MODE_XLAUI)
lmac->last_speed = 40000;
lmac->last_speed = SPEED_40000;
else
lmac->last_speed = 10000;
lmac->last_duplex = 1;
lmac->last_speed = SPEED_10000;
lmac->last_duplex = DUPLEX_FULL;
} else {
lmac->link_up = 0;
lmac->last_speed = SPEED_UNKNOWN;
Expand Down Expand Up @@ -1105,8 +1105,8 @@ static int bgx_lmac_enable(struct bgx *bgx, u8 lmacid)
} else {
/* Default to below link speed and duplex */
lmac->link_up = true;
lmac->last_speed = 1000;
lmac->last_duplex = 1;
lmac->last_speed = SPEED_1000;
lmac->last_duplex = DUPLEX_FULL;
bgx_sgmii_change_link_state(lmac);
return 0;
}
Expand Down

0 comments on commit 7f301cf

Please sign in to comment.