Skip to content

Commit

Permalink
platform/x86: amd-pmc: Fix undefined reference to __udivdi3
Browse files Browse the repository at this point in the history
It was reported that on i386 config

------
on i386:

ld: drivers/platform/x86/amd-pmc.o: in function `s0ix_stats_show':
amd-pmc.c:(.text+0x100): undefined reference to `__udivdi3'
-------

The reason for this is that 64-bit integer division is not supported
on 32-bit architecture. Use do_div macro to fix this.

Fixes: b9a4fa6 ("platform/x86: amd-pmc: Add support for logging s0ix counters")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org> # and build-tested
Link: https://lore.kernel.org/r/20210716153802.2929670-1-Shyam-sundar.S-k@amd.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
  • Loading branch information
Shyam Sundar S K authored and Hans de Goede committed Jul 17, 2021
1 parent 95edbbf commit 7f5231b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/platform/x86/amd-pmc.c
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ static int s0ix_stats_show(struct seq_file *s, void *unused)
exit_time = exit_time << 32 | ioread32(dev->fch_virt_addr + FCH_S0I3_EXIT_TIME_L_OFFSET);

/* It's in 48MHz. We need to convert it */
residency = (exit_time - entry_time) / 48;
residency = exit_time - entry_time;
do_div(residency, 48);

seq_puts(s, "=== S0ix statistics ===\n");
seq_printf(s, "S0ix Entry Time: %lld\n", entry_time);
Expand Down

0 comments on commit 7f5231b

Please sign in to comment.