Skip to content

Commit

Permalink
crypto: marvell/octeontx - Use dma_set_mask_and_coherent to simplify …
Browse files Browse the repository at this point in the history
…code

'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Christophe JAILLET authored and Herbert Xu committed Nov 27, 2020
1 parent d4f9afb commit 7f6c383
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 16 deletions.
10 changes: 2 additions & 8 deletions drivers/crypto/marvell/octeontx/otx_cptpf_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -212,15 +212,9 @@ static int otx_cpt_probe(struct pci_dev *pdev,
goto err_disable_device;
}

err = pci_set_dma_mask(pdev, DMA_BIT_MASK(48));
err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(48));
if (err) {
dev_err(dev, "Unable to get usable DMA configuration\n");
goto err_release_regions;
}

err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(48));
if (err) {
dev_err(dev, "Unable to get 48-bit DMA for consistent allocations\n");
dev_err(dev, "Unable to get usable 48-bit DMA configuration\n");
goto err_release_regions;
}

Expand Down
10 changes: 2 additions & 8 deletions drivers/crypto/marvell/octeontx/otx_cptvf_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -804,15 +804,9 @@ static int otx_cptvf_probe(struct pci_dev *pdev,
dev_err(dev, "PCI request regions failed 0x%x\n", err);
goto disable_device;
}
err = pci_set_dma_mask(pdev, DMA_BIT_MASK(48));
err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(48));
if (err) {
dev_err(dev, "Unable to get usable DMA configuration\n");
goto release_regions;
}

err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(48));
if (err) {
dev_err(dev, "Unable to get 48-bit DMA for consistent allocations\n");
dev_err(dev, "Unable to get usable 48-bit DMA configuration\n");
goto release_regions;
}

Expand Down

0 comments on commit 7f6c383

Please sign in to comment.