Skip to content

Commit

Permalink
NFS: Close page_mkwrite() races
Browse files Browse the repository at this point in the history
Follow up to Nick Piggin's patches to ensure that nfs_vm_page_mkwrite
returns with the page lock held, and sets the VM_FAULT_LOCKED flag.

See http://bugzilla.kernel.org/show_bug.cgi?id=12913

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Trond Myklebust authored and Linus Torvalds committed May 3, 2009
1 parent b4348f3 commit 7fdf523
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions fs/nfs/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -517,10 +517,10 @@ static int nfs_vm_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)

ret = nfs_updatepage(filp, page, 0, pagelen);
out_unlock:
if (!ret)
return VM_FAULT_LOCKED;
unlock_page(page);
if (ret)
ret = VM_FAULT_SIGBUS;
return ret;
return VM_FAULT_SIGBUS;
}

static struct vm_operations_struct nfs_file_vm_ops = {
Expand Down

0 comments on commit 7fdf523

Please sign in to comment.