Skip to content

Commit

Permalink
ALSA: ppc: drop if block with always false condition
Browse files Browse the repository at this point in the history
The remove callback is only called for devices that were probed
successfully before. As the matching probe function cannot complete
without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to
check this here.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20201126165950.2554997-1-u.kleine-koenig@pengutronix.de
  • Loading branch information
Uwe Kleine-König authored and Michael Ellerman committed Dec 3, 2020
1 parent ca3f969 commit 7ff9466
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions sound/ppc/snd_ps3.c
Original file line number Diff line number Diff line change
Expand Up @@ -1053,8 +1053,6 @@ static int snd_ps3_driver_remove(struct ps3_system_bus_device *dev)
{
int ret;
pr_info("%s:start id=%d\n", __func__, dev->match_id);
if (dev->match_id != PS3_MATCH_ID_SOUND)
return -ENXIO;

/*
* ctl and preallocate buffer will be freed in
Expand Down

0 comments on commit 7ff9466

Please sign in to comment.