Skip to content

Commit

Permalink
PNP: Compile all pnp built-in stuff in one module namespace
Browse files Browse the repository at this point in the history
This is cleanup mostly, nothing urgent.
I came up with it when looking at dynamic debug which can
enable pr_debug messages at runtime or boot param
for a specific module.

Advantages:
  - Any pnp code can make use of the moduleparam.h interface, the modules
    will show up as pnp.param.
  - Passing pnp.ddebug as kernel boot param will enable all pnp debug messages
    with my previous patch and CONFIG_DYNAMIC_DEBUG enabled.

Signed-off-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Thomas Renninger authored and Len Brown committed Oct 27, 2010
1 parent 45352bb commit 803711a
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
6 changes: 4 additions & 2 deletions drivers/pnp/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@
# Makefile for the Linux Plug-and-Play Support.
#

obj-y := core.o card.o driver.o resource.o manager.o support.o interface.o quirks.o
obj-y := pnp.o

pnp-y := core.o card.o driver.o resource.o manager.o support.o interface.o quirks.o

obj-$(CONFIG_PNPACPI) += pnpacpi/
obj-$(CONFIG_PNPBIOS) += pnpbios/
obj-$(CONFIG_ISAPNP) += isapnp/

# pnp_system_init goes after pnpacpi/pnpbios init
obj-y += system.o
pnp-y += system.o
6 changes: 3 additions & 3 deletions drivers/pnp/isapnp/Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#
# Makefile for the kernel ISAPNP driver.
#
obj-y += pnp.o
pnp-y := core.o compat.o

isapnp-proc-$(CONFIG_PROC_FS) = proc.o

obj-y := core.o compat.o $(isapnp-proc-y)
pnp-$(CONFIG_PROC_FS) += proc.o
3 changes: 2 additions & 1 deletion drivers/pnp/pnpacpi/Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#
# Makefile for the kernel PNPACPI driver.
#
obj-y += pnp.o

obj-y := core.o rsparser.o
pnp-y := core.o rsparser.o
5 changes: 3 additions & 2 deletions drivers/pnp/pnpbios/Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
#
# Makefile for the kernel PNPBIOS driver.
#
obj-y := pnp.o

pnpbios-proc-$(CONFIG_PNPBIOS_PROC_FS) = proc.o
pnp-y := core.o bioscalls.o rsparser.o

obj-y := core.o bioscalls.o rsparser.o $(pnpbios-proc-y)
pnp-$(CONFIG_PNPBIOS_PROC_FS) += proc.o

0 comments on commit 803711a

Please sign in to comment.