Skip to content

Commit

Permalink
rpcgss: remove redundant test on unsigned
Browse files Browse the repository at this point in the history
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
  • Loading branch information
Roel Kluin authored and J. Bruce Fields committed Apr 23, 2009
1 parent 0910697 commit 80492e7
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions fs/nfsd/export.c
Original file line number Diff line number Diff line change
Expand Up @@ -464,16 +464,11 @@ static int secinfo_parse(char **mesg, char *buf, struct svc_export *exp)
if (err)
return err;
/*
* Just a quick sanity check; we could also try to check
* whether this pseudoflavor is supported, but at worst
* an unsupported pseudoflavor on the export would just
* be a pseudoflavor that won't match the flavor of any
* authenticated request. The administrator will
* probably discover the problem when someone fails to
* authenticate.
* XXX: It would be nice to also check whether this
* pseudoflavor is supported, so we can discover the
* problem at export time instead of when a client fails
* to authenticate.
*/
if (f->pseudoflavor < 0)
return -EINVAL;
err = get_int(mesg, &f->flags);
if (err)
return err;
Expand Down

0 comments on commit 80492e7

Please sign in to comment.