Skip to content

Commit

Permalink
s2io: stop using net_device.{base_addr, irq}.
Browse files Browse the repository at this point in the history
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Cc: Jon Mason <jdmason@kudzu.us>
  • Loading branch information
Francois Romieu committed Apr 7, 2012
1 parent b5efab9 commit 80777c5
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions drivers/net/ethernet/neterion/s2io.c
Original file line number Diff line number Diff line change
Expand Up @@ -2847,6 +2847,7 @@ static int s2io_poll_inta(struct napi_struct *napi, int budget)
static void s2io_netpoll(struct net_device *dev)
{
struct s2io_nic *nic = netdev_priv(dev);
const int irq = nic->pdev->irq;
struct XENA_dev_config __iomem *bar0 = nic->bar0;
u64 val64 = 0xFFFFFFFFFFFFFFFFULL;
int i;
Expand All @@ -2856,7 +2857,7 @@ static void s2io_netpoll(struct net_device *dev)
if (pci_channel_offline(nic->pdev))
return;

disable_irq(dev->irq);
disable_irq(irq);

writeq(val64, &bar0->rx_traffic_int);
writeq(val64, &bar0->tx_traffic_int);
Expand Down Expand Up @@ -2885,7 +2886,7 @@ static void s2io_netpoll(struct net_device *dev)
break;
}
}
enable_irq(dev->irq);
enable_irq(irq);
}
#endif

Expand Down Expand Up @@ -3898,9 +3899,7 @@ static void remove_msix_isr(struct s2io_nic *sp)

static void remove_inta_isr(struct s2io_nic *sp)
{
struct net_device *dev = sp->dev;

free_irq(sp->pdev->irq, dev);
free_irq(sp->pdev->irq, sp->dev);
}

/* ********************************************************* *
Expand Down Expand Up @@ -7047,7 +7046,7 @@ static int s2io_add_isr(struct s2io_nic *sp)
}
}
if (sp->config.intr_type == INTA) {
err = request_irq((int)sp->pdev->irq, s2io_isr, IRQF_SHARED,
err = request_irq(sp->pdev->irq, s2io_isr, IRQF_SHARED,
sp->name, dev);
if (err) {
DBG_PRINT(ERR_DBG, "%s: ISR registration failed\n",
Expand Down Expand Up @@ -7909,9 +7908,6 @@ s2io_init_nic(struct pci_dev *pdev, const struct pci_device_id *pre)
goto bar1_remap_failed;
}

dev->irq = pdev->irq;
dev->base_addr = (unsigned long)sp->bar0;

/* Initializing the BAR1 address as the start of the FIFO pointer. */
for (j = 0; j < MAX_TX_FIFOS; j++) {
mac_control->tx_FIFO_start[j] = sp->bar1 + (j * 0x00020000);
Expand Down

0 comments on commit 80777c5

Please sign in to comment.