Skip to content

Commit

Permalink
IB/core: Fix error return code in add_port()
Browse files Browse the repository at this point in the history
Fix to return -ENOMEM in the add_port() error handling case instead of
0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Roland Dreier <roland@purestorage.com>
  • Loading branch information
Wei Yongjun authored and Roland Dreier committed Jun 24, 2013
1 parent f29fa1c commit 80b1504
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions drivers/infiniband/core/sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -545,8 +545,10 @@ static int add_port(struct ib_device *device, int port_num,

p->gid_group.name = "gids";
p->gid_group.attrs = alloc_group_attrs(show_port_gid, attr.gid_tbl_len);
if (!p->gid_group.attrs)
if (!p->gid_group.attrs) {
ret = -ENOMEM;
goto err_remove_pma;
}

ret = sysfs_create_group(&p->kobj, &p->gid_group);
if (ret)
Expand All @@ -555,8 +557,10 @@ static int add_port(struct ib_device *device, int port_num,
p->pkey_group.name = "pkeys";
p->pkey_group.attrs = alloc_group_attrs(show_port_pkey,
attr.pkey_tbl_len);
if (!p->pkey_group.attrs)
if (!p->pkey_group.attrs) {
ret = -ENOMEM;
goto err_remove_gid;
}

ret = sysfs_create_group(&p->kobj, &p->pkey_group);
if (ret)
Expand Down

0 comments on commit 80b1504

Please sign in to comment.