Skip to content

Commit

Permalink
ASoC: uda1380: Avoid accessing i2c bus when codec is disabled
Browse files Browse the repository at this point in the history
set_dai_fmt_both() callback is called from snd_soc_runtime_set_dai_fmt()
which is called from snd_soc_register_card(), but at this time codec
is not powered on yet. Replace direct i2c write with regcache write.

Fixes: 5f0aced (ASoC: rx1950_uda1380: Use static DAI format setup)
Fixes: 5cc10b9 (ASoC: h1940_uda1380: Use static DAI format setup)
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
  • Loading branch information
Vasily Khoruzhick authored and Mark Brown committed May 4, 2015
1 parent b787f68 commit 810e442
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/soc/codecs/uda1380.c
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ static int uda1380_set_dai_fmt_both(struct snd_soc_dai *codec_dai,
if ((fmt & SND_SOC_DAIFMT_MASTER_MASK) != SND_SOC_DAIFMT_CBS_CFS)
return -EINVAL;

uda1380_write(codec, UDA1380_IFACE, iface);
uda1380_write_reg_cache(codec, UDA1380_IFACE, iface);

return 0;
}
Expand Down

0 comments on commit 810e442

Please sign in to comment.