Skip to content

Commit

Permalink
netfilter: nf_tables: Carry s_idx in nft_rule_dump_ctx
Browse files Browse the repository at this point in the history
In order to move the context into struct netlink_callback's scratch
area, the latter must be unused first.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
  • Loading branch information
Phil Sutter authored and Florian Westphal committed Oct 10, 2023
1 parent 405c8fd commit 8194d59
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions net/netfilter/nf_tables_api.c
Original file line number Diff line number Diff line change
Expand Up @@ -3441,6 +3441,7 @@ static void audit_log_rule_reset(const struct nft_table *table,
}

struct nft_rule_dump_ctx {
unsigned int s_idx;
char *table;
char *chain;
bool reset;
Expand All @@ -3455,7 +3456,6 @@ static int __nf_tables_dump_rules(struct sk_buff *skb,
struct nft_rule_dump_ctx *ctx = cb->data;
struct net *net = sock_net(skb->sk);
const struct nft_rule *rule, *prule;
unsigned int s_idx = cb->args[0];
unsigned int entries = 0;
int ret = 0;
u64 handle;
Expand All @@ -3464,7 +3464,7 @@ static int __nf_tables_dump_rules(struct sk_buff *skb,
list_for_each_entry_rcu(rule, &chain->rules, list) {
if (!nft_is_active(net, rule))
goto cont_skip;
if (*idx < s_idx)
if (*idx < ctx->s_idx)
goto cont;
if (prule)
handle = prule->handle;
Expand Down Expand Up @@ -3498,7 +3498,7 @@ static int nf_tables_dump_rules(struct sk_buff *skb,
struct netlink_callback *cb)
{
const struct nfgenmsg *nfmsg = nlmsg_data(cb->nlh);
const struct nft_rule_dump_ctx *ctx = cb->data;
struct nft_rule_dump_ctx *ctx = cb->data;
struct nft_table *table;
const struct nft_chain *chain;
unsigned int idx = 0;
Expand Down Expand Up @@ -3547,7 +3547,7 @@ static int nf_tables_dump_rules(struct sk_buff *skb,
done:
rcu_read_unlock();

cb->args[0] = idx;
ctx->s_idx = idx;
return skb->len;
}

Expand Down

0 comments on commit 8194d59

Please sign in to comment.