Skip to content

Commit

Permalink
ASoC: img: Fix PM reference leak in img_i2s_in_probe()
Browse files Browse the repository at this point in the history
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yufen Yu <yuyufen@huawei.com>
Link: https://lore.kernel.org/r/20210524093521.612176-1-yuyufen@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Yufen Yu authored and Mark Brown committed Jun 3, 2021
1 parent 28b1701 commit 81aad47
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/soc/img/img-i2s-in.c
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ static int img_i2s_in_probe(struct platform_device *pdev)
if (ret)
goto err_pm_disable;
}
ret = pm_runtime_get_sync(&pdev->dev);
ret = pm_runtime_resume_and_get(&pdev->dev);
if (ret < 0)
goto err_suspend;

Expand Down

0 comments on commit 81aad47

Please sign in to comment.