Skip to content

Commit

Permalink
net: ethernet: ti: am65-cpts: update ret when ptp_clock is ERROR
Browse files Browse the repository at this point in the history
We always have to update the value of ret, otherwise the
 error value may be the previous one.

Fixes: f6bd595 ("net: ethernet: ti: introduce am654 common platform time sync driver")
Signed-off-by: Wang Qing <wangqing@vivo.com>
[grygorii.strashko@ti.com: fix build warn, subj add fixes tag]
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Link: https://lore.kernel.org/r/20201112164541.3223-1-grygorii.strashko@ti.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Wang Qing authored and Jakub Kicinski committed Nov 13, 2020
1 parent 8c07205 commit 81e329e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/ethernet/ti/am65-cpts.c
Original file line number Diff line number Diff line change
Expand Up @@ -1001,8 +1001,7 @@ struct am65_cpts *am65_cpts_create(struct device *dev, void __iomem *regs,
if (IS_ERR_OR_NULL(cpts->ptp_clock)) {
dev_err(dev, "Failed to register ptp clk %ld\n",
PTR_ERR(cpts->ptp_clock));
if (!cpts->ptp_clock)
ret = -ENODEV;
ret = cpts->ptp_clock ? PTR_ERR(cpts->ptp_clock) : -ENODEV;
goto refclk_disable;
}
cpts->phc_index = ptp_clock_index(cpts->ptp_clock);
Expand Down

0 comments on commit 81e329e

Please sign in to comment.