Skip to content

Commit

Permalink
Revert "serial: 8250: Let serial core initialise spin lock"
Browse files Browse the repository at this point in the history
This reverts commit 679193b.

It appears that in QEmu the lock has been initialised differently
(it wasn't obvious on real hardware during testing). Let's
revert the change until the better approach will be developed.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200802111612.36189-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Andy Shevchenko authored and Greg Kroah-Hartman committed Aug 2, 2020
1 parent 679193b commit 81f0f78
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/tty/serial/8250/8250_port.c
Original file line number Diff line number Diff line change
Expand Up @@ -3194,6 +3194,7 @@ void serial8250_init_port(struct uart_8250_port *up)
{
struct uart_port *port = &up->port;

spin_lock_init(&port->lock);
port->ops = &serial8250_pops;
port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);

Expand Down

0 comments on commit 81f0f78

Please sign in to comment.